Repository navigation
chore(life): #5228 datepicker cleanup and caption artifacts - #5230
Merged
Merged
Conversation
Remove dead macOS yearPage helper, fix yearsPerPage sync comment, and reserve Life variation chip space only while Mod page-jump hints are visible. Add narrow sidebar web artifact captures for the 20-year caption grid. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 576.8 KB gzip (+0.0 KB vs main) |
Reserve Mod chip space invisibly to avoid title layout shift, remove dead mac year-page web helpers, add LifeView layout assertion, and replace artifact-only e2e with narrow light/dark year-grid checks. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Sort Tailwind classes for biome and match react-datepicker year-text selectors. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follow-up to #5228:
DatePickerCaption.yearPageand fixyearsPerPagesync commentw-7Mod chip slot (invisiblewhen hints hidden) so the variation title does not shift on Mod press;LifeViewtest asserts stablegetBoundingClientRect().leftmacYearPageContaining/macYearRangeCaptionweb helperse2e/life/caption-year-grid-narrow.spec.ts(360px, light + dark): 20-year page,Years 1981 to 2000, sidebar overflow check (replaces@artifactspec)Verify
Pending CI on head
8879ebee3.